search

mighty-gerbils / gerbil

Gerbil Scheme
https://cons.io
GNU Lesser General Public License v2.1
1.14k stars 112 forks source link

define vector-ref-set! and u8vector-ref-set! in core prelude #1071

Closed leahneukirchen closed 7 months ago

leahneukirchen commented 7 months ago

I moved the existing documentation, perhaps there's a better place tho.

netlify[bot] commented 7 months ago

Deploy request for elastic-ritchie-8f47f9 pending review.

Visit the deploys page to approve it

Name Link
Latest commit 2515423c12562af873390fdd982287d9987dc038
fare commented 7 months ago

I think you are also supposed to export all those things from the suitable modules in prelude/core.ss.

leahneukirchen commented 7 months ago

These things have (export #t) no?

fare commented 7 months ago

There's exporting from those particular runtime modules, that will put things in the runtime environment, and then there is exporting from the prelude/core.ss that will make those things visible without explicit importing from the runtime.

fare commented 7 months ago

OK, it looks like I'm confused and you shouldn't need anything else. If you tested that it works in interpreted and compiled code, let's just do it.