search

mighty-gerbils / gerbil

Gerbil Scheme
https://cons.io
GNU Lesser General Public License v2.1
1.15k stars 111 forks source link

Fix the "Homebrew uses installed libgambit" issue. #1113

Closed drewc closed 8 months ago

drewc commented 8 months ago

The other commits are a rebase

netlify[bot] commented 8 months ago

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
Latest commit e0f28ff186675a224df983f00f53da0091cda146
Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/65b89358d857f6000826d968
Deploy Preview https://deploy-preview-1113--elastic-ritchie-8f47f9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vyzo commented 8 months ago

build failed.

drewc commented 8 months ago

We really need to get rid of the transient falling SSL test. Out of the last 50 checks on PR's, 42 or so failed with the badssl not being live transient not our fault failure.

This one changes nothing about the build or the tests so failing tests are OUR fault. Sigh.

On Wed, Jan 24, 2024 at 10:23 PM vyzo @.***> wrote:

build failed.

— Reply to this email directly, view it on GitHub https://github.com/mighty-gerbils/gerbil/pull/1113#issuecomment-1909430483, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADVTXLFGNQIHOIADHOYNETYQH267AVCNFSM6AAAAABCJ33EDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGQZTANBYGM . You are receiving this because you authored the thread.Message ID: @.***>

vyzo commented 8 months ago

yar, flaky tests no good -- go ahead and cond-expand it out.

drewc commented 8 months ago

By cond-expand you mean #; ? Or "What do I cond expand in order to never expand?" :)

On Thu, Jan 25, 2024 at 9:20 AM vyzo @.***> wrote:

yar, flaky tests no good -- go ahead and cond-expand it out.

— Reply to this email directly, view it on GitHub https://github.com/mighty-gerbils/gerbil/pull/1113#issuecomment-1910657181, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADVTXNLASW6DRSBVRMZUNTYQKH5DAVCNFSM6AAAAABCJ33EDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQGY2TOMJYGE . You are receiving this because you authored the thread.Message ID: @.***>

vyzo commented 8 months ago

just put it in a cond expand arm (enable-badssl-test or something), so that it does not run by default. do NOT comment it out.