search

mighty-gerbils / gerbil

Gerbil Scheme
https://cons.io
GNU Lesser General Public License v2.1
1.13k stars 111 forks source link

libgerbil.so -> libgerbil.dylib on macOS #1177

Closed jsulmont closed 3 months ago

jsulmont commented 3 months ago

Closes #1166

netlify[bot] commented 3 months ago

Deploy request for elastic-ritchie-8f47f9 pending review.

Visit the deploys page to approve it

Name Link
Latest commit cfa374fc2e47d37cef6c8154e3558b430acb7177
jsulmont commented 3 months ago

You also need to change src/build/build-libgerbil.ss to name it .dylib.

Not sure what u mean here

vyzo commented 3 months ago

You also need to change src/build/build-libgerbil.ss to name it .dylib.

Not sure what u mean here

It has to build it as liberbil.dylib, it currently names it libgerbil.so

vyzo commented 3 months ago

@drewc assigned you this, can you test on the M3 to make sure it works as intended?

vyzo commented 3 months ago

I still think we need to change this in build-libgerbil.ss:

...
        (libgerbil
          (if (eq? mode 'shared)
            (library-file-path "libgerbil.so")
            (library-file-path "libgerbil.a")))

with a cond-expand for darwin that names it .dylib.

vyzo commented 3 months ago

We probably should add a MacOS worker to CI/CD so that the build/tests run on the Mac too!