mighty-gerbils / gerbil

Gerbil Scheme
https://cons.io
GNU Lesser General Public License v2.1
1.16k stars 112 forks source link

Improve MOP safety #1182

Closed vyzo closed 8 months ago

vyzo commented 8 months ago

Specifically, class-slot-offset and find-method need to be immune to type errors for symbolic table references (which doesn't check anything).

Also normalizes the behavior of class-instance?.

Impetus:

Gerbil v0.18.1-72-gb280d037 on Gambit v4.9.5-124-g6d1a9a9b
> (defclass Point (x y))
> (def a (Point 1 2))

Process scheme segmentation fault (core dumped)

Not good UX.

netlify[bot] commented 8 months ago

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
Latest commit 8bcf6230fb6e0930f0672d6ba375ca27f2d14806
Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/65faedc32a23cf0008aa53db
Deploy Preview https://deploy-preview-1182--elastic-ritchie-8f47f9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.