search

mightymos / ReedTripRadio

Alternative firmware for wireless 433MHz door/window reed sensors triggered by magnetic contacts.
BSD 2-Clause "Simplified" License
153 stars 7 forks source link

GH Actions to build firmware #3

Closed Jason2866 closed 1 year ago

Jason2866 commented 1 year ago

upload the builded firmware in section release when drafting a release tagging like v*.*.*

mightymos commented 1 year ago

Thanks for the PR. Sorry, I am on Windows with msys2 which supports bash and pacman package manager. Is it possible or desired to accommodate Windows?

Jason2866 commented 1 year ago

Why is the platform relevant where the Firmware is built? Or is related to maintaining? If maintaining is the reason, i do understand. Setting up an GH Windows env to build is not so easy. Imho a bit strange since in the end an Linux system is used. Stopped using Windows in 2021. Happy with a Macbook Air M1. Awesome performance. Tbh. Dont know how to install the needed stuff in GH Windows env for this.

mightymos commented 1 year ago

I did not understand where a GH Action runs at first. Merging.

Jason2866 commented 1 year ago

@mightymos Forgot, the GH actions needs write permissions to publish the release. You find that in GH settings -> Actions -> General 577F8F0E-20C7-4F6D-9AD7-3462628B0B3A

mightymos commented 1 year ago

I show identical settings to your screenshot by default. Am I missing something else?

Jason2866 commented 1 year ago

Probably not. To start the action you have to draft a release 637CF0AA-4E73-4BA0-B856-B358FE69E0CE Push the menu button "Drafta new release" and choose a version number you want in format v*.*.* and than push publish menu button

Jason2866 commented 1 year ago

If you do some GH Actions, you get addicted to ;-)

mightymos commented 1 year ago

Got it, thanks. There are actually two different parts in these door sensors so far...that run at different system clocks. The makefile and generated hex file would probably need to take this into account in the future.

Jason2866 commented 1 year ago

Maybe you can do a Makefile which is building all different variants? Small change for releasing all builded variants.

mightymos commented 1 year ago

Yes, will be needed eventually. I will have to learn more about makefiles.