migliori / universal-icon-picker

Vanilla JS Icon Picker for any Icon Library
https://universal-icon-picker.miglisoft.com
MIT License
78 stars 9 forks source link

Note down version on icon set json files #7

Closed fsbraun closed 1 year ago

fsbraun commented 1 year ago

@migliori Still love your picker! Here's one thing that came to my mind:

To track down which version of the icon set belongs to I suggest to add a version property (string) which notes down the version of the icon set was used when generating the json file.

This needs not to be used by the picker but helps humans to keep track of the supported icon sets.

migliori commented 1 year ago

That's a good idea. I added the versions to the JSON icon files.

fsbraun commented 1 year ago

@migliori One more question: How do you create the JSON files? I saw the tool for FontAwesome. Say, I'd like to contribute an update on some library (bootstrap, e.g.). How can I create the JSON file?

migliori commented 1 year ago

Hi Fabian,

I had to build the tool for FontAwesome, but for others libraries I did it as I could, according to the data I could retrieve: copied/pasted the lists of icons in vs-code then formatted them.

Gilles Migliori - Web developer https://codecanyon.net/user/migli/portfoliohttps://www.miglisoft.com+33 9 54 71 79 93 +33 6 99 07 24 43

------ Message d'origine ------ De "Fabian Braun" @.> À "migliori/universal-icon-picker" @.> Cc "Gilles Migliori" @.>; "State change" @.> Date 31/03/2023 09:49:57 Objet Re: [migliori/universal-icon-picker] Note down version on icon set json files (Issue #7)

One more question: How do you create the JSON files? I saw the tool for FontAwesome. Say, I'd like to contribute an update on some library (bootstrap, e.g.). How can I create the JSON file?

— Reply to this email directly, view it on GitHub https://github.com/migliori/universal-icon-picker/issues/7#issuecomment-1491464260, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZVHVHL5L34GK36S62XOJDW62ECLANCNFSM6AAAAAAVWKCX2I. You are receiving this because you modified the open/close state.Message ID: @.***>