migme / surfboard

:surfer: Widget to embed Migme in web apps
4 stars 0 forks source link

JSON instead of LCOV #24

Closed sebdeckers closed 9 years ago

sebdeckers commented 9 years ago

Trying to get higher definition coverage reporting on Codecov

codecov-io commented 9 years ago

Current coverage is 69.29%

Merging #24 into master will change coverage by 0% by bfb8d29

Coverage Diff

@@            master     #24   diff @@
======================================
  Files           13      13       
  Stmts          140     140       
  Branches        38      38       
  Methods         64      64       
======================================
  Hit             97      97       
  Partial          0       0       
  Missed          43      43       

Uncovered Suggestions

  1. +5.00% via ...s/mig/login/login.js#9...15
  2. +3.57% via .../login/parentHost.js#4...8
  3. +3.57% via ...mig/login/closest.js#4...8
  4. See 4 more...

Powered by Codecov

codecov-io commented 9 years ago

Current coverage is 69.29%

Merging mocha into master will change coverage by 0% by 14c9225

Coverage Diff

@@            master   mocha   diff @@
======================================
  Files           13      13       
  Stmts          140     140       
  Branches        38      38       
  Methods         64      64       
======================================
  Hit             97      97       
  Partial          0       0       
  Missed          43      43       

Uncovered Suggestions

  1. +5.00% via ...s/mig/login/login.js#9...15
  2. +3.57% via .../login/parentHost.js#4...8
  3. +3.57% via ...mig/login/closest.js#4...8
  4. See 4 more...

Powered by Codecov

sebdeckers commented 9 years ago

Managed to lower the coverage further... :worried:

sebdeckers commented 9 years ago

Lies, damn lies, and test coverage!

eddiemoore commented 9 years ago

I think use the lcov.info file. There seems to be something wrong with isparta/istanbul and coverage.json file