search

migme / surfboard

:surfer: Widget to embed Migme in web apps
4 stars 0 forks source link

checking coverage output #25

Closed stevepeak closed 8 years ago

stevepeak commented 9 years ago

Please do not merge, just checking out the coverage data. Thanks!

sebdeckers commented 9 years ago

Running this locally: https://gist.github.com/cbas/eb99a3045df80d5e9e0d (Please forgive the Windows paths. Hope that doesn't make it worse.)

sebdeckers commented 9 years ago

@eddiemoore Aside: Apparently the build fails because Travis can not connect to Sauce Labs when triggered by a PR from a fork. We should look into using local PhantomJS for forked PR builds.

@stevepeak Thanks very much for your personal attention. Really appreciate any help to get our code coverage results working even better.

stevepeak commented 9 years ago

@cbas thanks for sharing this with me. I'm working on this now. Do you have the commit this report is in reference to so I can verify some information.

Thanks!

stevepeak commented 9 years ago

source from app/components/mig/me/me.js

1  /*global HTMLElement */
2  import insertCss from 'insert-css'
3  import Beachball from 'migme-beachball/src'
4  import MigButton from '../button'
5  import MigPanel from '../panel'
6  import css from './me.styl'
7  import html from './me.jade'
8  
9  class Me extends HTMLElement {
10   createdCallback () {
11     this.beachball = new Beachball()
12 
13     let root = this.createShadowRoot()

from https://gist.github.com/cbas/eb99a3045df80d5e9e0d#file-info-lcov-L108-L115

BRDA:8,1,0,1
BRDA:8,1,1,1
BRDA:8,2,0,1
BRDA:8,2,1,0
BRDA:8,3,0,1
BRDA:8,3,1,0
BRDA:8,4,0,0
BRDA:8,4,1,1
BRDA:10,5,0,0
BRDA:10,5,1,6
BRDA:10,6,0,6
BRDA:10,6,1,6
BRDA:12,7,0,0
BRDA:12,7,1,0

from http://ltp.sourceforge.net/coverage/lcov/geninfo.1.php

Branch coverage information is stored which one line per branch:
         BRDA:<line number>,<block number>,<branch number>,<taken>

Therefore line 8 and 12 have coverage data which is expressed properly on Codecov here but does not line up on the code....

sebdeckers commented 9 years ago

@stevepeak This log came from running against master. That's d3bf8fa55271c11876b7a005b32228ffa13f5d5a as of last night.

The tests and app are written in ES6, yes. They get transpiled using Browserify with Babelify and karma-source-map-support to be able to debug with source maps in the browser. The coverage comes from Istanbul, with Isparta as instrumenter. There is a broken link somewhere in the source map chain, I think.

:sweat_smile:

sebdeckers commented 9 years ago

FYI I've also had issues running karma with code coverage and source maps simultaneously. I suspect Istanbul is at fault since it has no support for source maps yet (WIP branch).

stevepeak commented 9 years ago

@eddiemoore or @cbas can we schedule a time to chat on Skype to try to fix this issue. I need to learn more about whats going on with ES6's issues. Thanks

sebdeckers commented 9 years ago

Sure -- we'll hang out in https://gitter.im/codecov/support

On 26 June 2015 at 05:47, Steve Peak notifications@github.com wrote:

@eddiemoore https://github.com/eddiemoore or @cbas https://github.com/cbas can we schedule a time to chat on Skype to try to fix this issue. I need to learn more about whats going on with ES6's issues. Thanks

— Reply to this email directly or view it on GitHub https://github.com/migme/surfboard/pull/25#issuecomment-115407581.