search

migraphx-benchmark / AMDMIGraphX

AMD's graph optimization engine.
https://rocmsoftwareplatform.github.io/AMDMIGraphX/doc/html/
MIT License
0 stars 1 forks source link

PReLu shape mismatch #126

Closed attila-dusnoki-htec closed 9 months ago

attila-dusnoki-htec commented 10 months ago

Failing tests:

attila-dusnoki-htec commented 10 months ago 
ERROR: test_PReLU_1d_multiparam_cpu (__main__.OnnxBackendPyTorchConvertedModelTest)
RuntimeError: /code/AMDMIGraphX/src/common.cpp:48: operator(): COMPUTE_BROADCASTLEN: shape {3} and {2, 3, 4} mismatch!

ERROR: test_PReLU_2d_multiparam_cpu (__main__.OnnxBackendPyTorchConvertedModelTest)
RuntimeError: /code/AMDMIGraphX/src/common.cpp:48: operator(): COMPUTE_BROADCASTLEN: shape {3} and {2, 3, 4, 5} mismatch!

ERROR: test_PReLU_3d_multiparam_cpu (__main__.OnnxBackendPyTorchConvertedModelTest)
RuntimeError: /code/AMDMIGraphX/src/common.cpp:48: operator(): COMPUTE_BROADCASTLEN: shape {3} and {2, 3, 4, 5, 6} mismatch!
attila-dusnoki-htec commented 10 months ago

ORT and ONNX-Tensorflow ignore these test due to outdated/wrong test cases: https://github.com/onnx/onnx-tensorflow/blob/main/test/backend/test_onnx_backend.py#L56 https://github.com/microsoft/onnxruntime/blob/main/onnxruntime/test/onnx/main.cc#L646-L651

attila-dusnoki-htec commented 10 months ago

We should skip it with the same message as TensorFlow:

# PRelu OnnxBackendPyTorchConvertedModelTest has wrong dim for broadcasting
backend_test.exclude(r'[a-z,_]*PReLU_[0-9]d_multiparam[a-z,_]*')
attila-dusnoki-htec commented 9 months ago

Fixed in https://github.com/migraphx-benchmark/AMDMIGraphX/issues/131