migraphx-benchmark / AMDMIGraphX

AMD's graph optimization engine.
https://rocmsoftwareplatform.github.io/AMDMIGraphX/doc/html/
MIT License
0 stars 1 forks source link

Cleanup of LSTM and RNN activation functions #160

Closed nives-vukovic closed 5 months ago

nives-vukovic commented 6 months ago

Current onnx parsing is not in line with the specification that states activation function number should be 1/2 for RNN and 3/6 for LSTM. Instead there are helper functions that fill in missing functions in a slightly arbitrary way, instead of reporting errors (handled that way in onnx runtime). This expands to tests that also have lower or higher number of activation functions than needed.

Cleanup done for the GRU operator during review process as part of https://github.com/ROCm/AMDMIGraphX/pull/2415