search

migraphx-benchmark / AMDMIGraphX

AMD's graph optimization engine.
https://rocmsoftwareplatform.github.io/AMDMIGraphX/doc/html/
MIT License
0 stars 1 forks source link

Reduce operators axes input parse error #68

Closed mirza-halilcevic closed 6 months ago

mirza-halilcevic commented 1 year ago

Tests for ONNX opset 18 versions of reduce operators fail due to axes now being an input instead of an attribute.

mirza-halilcevic commented 1 year ago

Cases when the axes input values can be parsed from the graph are properly handled by MIGraphX. An axes input that can't be evaluated during parsing is not yet supported. The current code relies on axes values being known during parsing to compute the output shape correctly. With axes as an input the output shape has to be dynamic.

This applies to all operators where the output shape depends on the input values, like Slice and Squeeze. The ONNX backend tests for these are currently disabled.

music-dino commented 1 year ago

Parsing and reference implementation have been updated. MIGraphX currently does not support GPU operators where the output shapes is dependent on runtime input. This capability will be added some time in the future as part of furthering dynamic shape support. Once this is enabled, the GPU operator can be updated.