search

migraphx-benchmark / AMDMIGraphX

AMD's graph optimization engine.
https://rocmsoftwareplatform.github.io/AMDMIGraphX/doc/html/
MIT License
0 stars 1 forks source link

Pool dilations attribute #70

Closed mirza-halilcevic closed 9 months ago

mirza-halilcevic commented 1 year ago

The dilations attribute has been added to the AveragePool operator since opset v19 and support needs to be added.

mirza-halilcevic commented 1 year ago

The dilations attribute has been present in the MaxPool operator since opset 10. However, support for it has yet to be added and tests for MaxPool that depend on the dilations attribute are currently excluded.

mirza-halilcevic commented 1 year ago

We added parsing support for the dilations attribute and modified the reference implementation accordingly. The GPU target implementation uses the MIOpen pooling layer which at the moment doesn't support dilations. Neither does DNNL in the CPU target implementation.

attila-dusnoki-htec commented 1 year ago

The latest version of the PR added the missing test and fixed the logic for calculating dilations. As mentioned above, the GPU version (MIOpen) does not support dilations. As a workaround, we will investigate solutions with separating padding and calculating the kernels with slice op.