search

migrating-ravens / RavenMigrations

A small migrations framework to help you manage your RavenDB Instance.
MIT License
53 stars 24 forks source link

Patch migrations, Alternate versioning scheme, version number by convention #25

Closed brunomlopes closed 8 years ago

brunomlopes commented 9 years ago

This is a big PR, and I expect things to change and have a discussion around these changes :)

A description of (most of) the changes can be seen on a change to the readme.

I would have to check, but this might have a breaking change as far as migration doc ids go.

dportzline83 commented 9 years ago

Do you think you could split the different logical changes being made here into separate PRs? There is a lot going on in here, and I am having trouble keeping the purpose of each change straight. There are at least two PRs I can see out of this: one for patch migrations, and the other for the alternate versioning scheme, correct?

brunomlopes commented 9 years ago

I can try, yeah. It's big because we've been using and evolving it for the past year or so.

Patch migrations should be straightforward to extract, as they're mostly subclasses of Migration.

Then there's the alternate versioning scheme which consists of supporting quads of migrations.

Finally, there's "migration number by convention". This one uses a different collector that infers the number from the name and namespace, instead of having to decorate the class. It does not yet support profiles, but I think it can be made to support them as separate properties.

I'l try to split them into different PRs over the next week or so..

absynce commented 8 years ago

Closing this in favor of the feature introduced in #37.