search

migrating-ravens / RavenMigrations

A small migrations framework to help you manage your RavenDB Instance.
MIT License
53 stars 24 forks source link

Move to 4.0? #43

Closed JudahGabriel closed 6 years ago

JudahGabriel commented 6 years ago

Hi @dportzline83

RavenMigrations is currently on Raven 2.5, which is quite outdated. Would you accept a PR that upgrades to the latest Raven 4.x?

JudahGabriel commented 6 years ago

Also, could I migrate the code to .NET Core? Would you accept a PR for that?

dportzline83 commented 6 years ago

I have no issues with those ideas. I'm not using Raven anymore, so I don't have much of a stake in it. I'd be curious if others who are watching this thread have opinions.

On Tue, Jul 17, 2018, 07:58 Judah Gabriel Himango notifications@github.com wrote:

Also, could I migrate the code to .NET Core? Would you accept a PR for that?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/migrating-ravens/RavenMigrations/issues/43#issuecomment-405613045, or mute the thread https://github.com/notifications/unsubscribe-auth/AD8LkAtzbx2-nW8BTQHqbHIXeHEThw-yks5uHfuZgaJpZM4VTAq7 .

JudahGabriel commented 6 years ago

Thanks!

If you think you won't be maintaining this repository any longer, I'd be willing to take over ownership. (I can still keep your name as an author in the NuGet package if you like.)

dportzline83 commented 6 years ago

Yeah, I'm happy to have someone else take over. I'm on vacation today, but I'll try to get back with you later this week. Remind me if I forget :)

On Tue, Jul 17, 2018, 11:13 Judah Gabriel Himango notifications@github.com wrote:

Thanks!

If you think you won't be maintaining this repository any longer, I'd be willing to take over ownership. (I can still keep your name as an author in the NuGet package if you like.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/migrating-ravens/RavenMigrations/issues/43#issuecomment-405676403, or mute the thread https://github.com/notifications/unsubscribe-auth/AD8LkPcv71gUTxl0GRhnKDjhYqD8fL-dks5uHilRgaJpZM4VTAq7 .

JudahGabriel commented 6 years ago

Sounds good. Enjoy your vacation.

dportzline83 commented 6 years ago

@JudahGabriel I've added you as a collaborator on the repository. Looks like @khalidabuhakmeh already added you to the Nuget.

JudahGabriel commented 6 years ago

Yep, thanks! I submitted a PR for this: https://github.com/migrating-ravens/RavenMigrations/pull/44 - it upgrades this project to use .NET Core 2.1 and Raven 4.