search

migrating-ravens / RavenMigrations

A small migrations framework to help you manage your RavenDB Instance.
MIT License
53 stars 24 forks source link

Migrations should be async #51

Closed JudahGabriel closed 7 months ago

JudahGabriel commented 5 years ago

Since migrations are talking to a remote service, it seems like migrations should all return Task, rather than void.

And that MigrationRunner.Run should actually be MigrationRunner.RunAsync.

This would let migration code use async/await and some of the APIs that are more natural in Raven; no need to Task.Wait or other kludges.

JudahGabriel commented 7 months ago

One problem with this is that migrations are usually run in the Startup/Program code, which is usually not async.

And given that migration code is run on startup, asynchrony isn't very important. Closing.