search

migtools / crane-runner

Apache License 2.0
2 stars 11 forks source link

Stop hard coding crane-runner in all tasks #58

Closed jmontleon closed 2 years ago

jmontleon commented 2 years ago

Related to https://github.com/konveyor/crane-operator/issues/60 and https://github.com/konveyor/crane-runner/issues/57

github-actions[bot] commented 2 years ago

This issue is currently awaiting triage. If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance. The triage/accepted label can be added by org members by writing /triage accepted in a comment.

eriknelson commented 2 years ago

/triage accepted /priority critical

github-actions[bot] commented 2 years ago

This issue synced with: https://issues.redhat.com/browse/MTRHO-115

eriknelson commented 2 years ago

/triage accepted

djzager commented 2 years ago

Just for reference, this is where (in crane-operator) the ClusterTask image is overridden https://github.com/konveyor/crane-operator/blob/ebd6f4753da775dafdae8afae423e37b8eca123b/controllers/operatorconfig_controller.go#L394-L396

djzager commented 2 years ago

It also appears, I hadn't noticed this, you can specify the image via params. https://github.com/tektoncd/catalog/blob/main/task/docker-build/0.1/docker-build.yaml#L71

jmontleon commented 2 years ago

Ya, I guess this isn't an issue afterall. I'll go ahead and close it.