Closed mturley closed 2 years ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ibolton336, mturley
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Resolves #105
Adds the following modal when you reach the import wizard page:
Note: at first we intended to have this modal only appear if you are not coming from the Add page, since the Add page card has a short similar description. To that end I implemented a
?from=
URL parameter that I then reverted when we decided to have it show up no matter the source. If it ever becomes useful later, you can see that implementation in https://github.com/konveyor/crane-ui-plugin/pull/114/commits/ea5f0c4b708792c80e240305ed72d13855c6c30e . This was also initially used as the method for navigating back to the right place on Cancel, before I realized we can just usehistory.goBack()
.In order to implement the "don't show this again" checkbox, this PR also introduces a new common hook
useLocalStorage
that would be a good contribution to lib-ui later on (see https://github.com/konveyor/lib-ui/issues/106). This is a simpler alternative to the LocalStorageContext we implemented in forklift-ui.