WIP: feat(image-sync): update pipelines for image

migtools / crane-ui-plugin

OpenShift Dynamic Plugin for Crane UI

1 stars 11 forks source link

WIP: feat(image-sync): update pipelines for image #119

Closed djzager closed 2 years ago

djzager commented 2 years ago

Implementes konveyor/enhancements#77 without introducing a whole new pipeline.

The idea here is that we can run the image-sync task without creating a whole new pipeline to worry about. If there are no imagestreams that need skopeo sync, the task just returns success. This could prevent us from having to implement logic for discovering ImageStreams.

Fixes #110 Fixes #111

Screenshots:

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djzager

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/konveyor/crane-ui-plugin/blob/main/OWNERS)~~ [djzager] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

djzager commented 2 years ago

Here is a PipelineRun failing because the destination's cluster registry had not yet been properly exposed:

djzager commented 2 years ago

Closing in favor of #120