migtools / crane-ui-plugin

OpenShift Dynamic Plugin for Crane UI
1 stars 11 forks source link

Add authorize flags to ConsolePlugin proxy services #68

Closed mturley closed 2 years ago

mturley commented 2 years ago

After all the fuss about this authorize flag on the ConsolePlugin proxy config, of course I forgot to actually add it. Because of https://bugzilla.redhat.com/show_bug.cgi?id=2058424 and the CORS workaround https://github.com/konveyor/crane-ui-plugin/pull/61, the behavior without these flags is actually correct (only secret-service is actually being used via ConsolePlugin proxy and we do want that one to use authorize: true, so the bug forcing authorize to true is fine) which is why we were able to demo things just fine without them.

When the bug fix is released and the CORS workaround is reverted, we'd suddenly start seeing secret-service fail as the auth token wouldn't be attached to those requests without this flag. This PR proactively fixes that.