search

migtools / crane-ui-plugin

OpenShift Dynamic Plugin for Crane UI
1 stars 11 forks source link

Revert "Workaround: make direct CORS requests to crane-reverse-proxy's route instead of using ConsolePlugin proxy (#61)" #77

Closed mturley closed 2 years ago

mturley commented 2 years ago

Reverts #61 now that we have the bug fix https://github.com/openshift/console/pull/11108 backported to 4.10. Tested on a 4.10.10 cluster and it works great.

Resolves #45 Resolves https://issues.redhat.com/browse/MIG-1093

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djzager, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/konveyor/crane-ui-plugin/blob/main/OWNERS)~~ [djzager,mturley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment