search

migtools / mig-ui

Openshift Migration UI
Apache License 2.0
10 stars 31 forks source link

[Backport - 1.7.2] Bug 2040693: Update repository name validation to use name length validation #1450

Closed ibolton336 closed 2 years ago

ibolton336 commented 2 years ago

Add conditionals to prevent bug on empty storage spec fields

openshift-ci[bot] commented 2 years ago

@ibolton336: This pull request references Bugzilla bug 2040693, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug * bug is open, matching expected state (open) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xjiang@redhat.com), skipping review request.

In response to [this](https://github.com/konveyor/mig-ui/pull/1450): >[Backport - 1.7.2] Bug 2040693: Update repository name validation to use name length validation Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ibolton336 commented 2 years ago

depends on https://github.com/konveyor/mig-ui/pull/1448

openshift-ci[bot] commented 2 years ago

@ibolton336: This pull request references Bugzilla bug 2040693. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/konveyor/mig-ui/pull/1450): >[Backport - 1.7.2] Bug 2040693: Update repository name validation to use name length validation Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibolton336

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/konveyor/mig-ui/blob/release-1.7.2/OWNERS)~~ [ibolton336] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@ibolton336: This pull request references Bugzilla bug 2040693, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug * bug is open, matching expected state (open) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xjiang@redhat.com), skipping review request.

In response to [this](https://github.com/konveyor/mig-ui/pull/1450): >[Backport - 1.7.2] Bug 2040693: Update repository name validation to use name length validation Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibolton336

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/konveyor/mig-ui/blob/release-1.7.2/OWNERS)~~ [ibolton336] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@ibolton336: All pull requests linked via external trackers have merged:

Bugzilla bug 2040693 has been moved to the MODIFIED state.

In response to [this](https://github.com/konveyor/mig-ui/pull/1450): >[Backport - 1.7.2] Bug 2040693: Update repository name validation to use name length validation Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.