search

migtools / mig-ui

Openshift Migration UI
Apache License 2.0
10 stars 31 forks source link

Bug 2078459: Prevent migStorageRef from being added to plans that don't already have one #1452

Closed mturley closed 2 years ago

mturley commented 2 years ago

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2078459 after #1424 failed QA.

1424 prevents the migStorageRef from being added to the plan when it is first created, but not when it is updated. This PR fixes that update case.

openshift-ci[bot] commented 2 years ago

@mturley: This pull request references Bugzilla bug 2078459, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug * bug is open, matching expected state (open) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ssingla@redhat.com), skipping review request.

In response to [this](https://github.com/konveyor/mig-ui/pull/1452): >Bug 2078459: Prevent migStorageRef from being added to plans that don't already have one Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibolton336, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/konveyor/mig-ui/blob/master/OWNERS)~~ [ibolton336,mturley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@mturley: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2078459 has not been moved to the MODIFIED state.

In response to [this](https://github.com/konveyor/mig-ui/pull/1452): >Bug 2078459: Prevent migStorageRef from being added to plans that don't already have one Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.