search

migtools / mig-ui

Openshift Migration UI
Apache License 2.0
10 stars 31 forks source link

Move devDependencies over to main deps #1469

Closed ibolton336 closed 2 years ago

ibolton336 commented 2 years ago

Fixes the build error resulting from using yarn --production flag in docker file.

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibolton336, rayfordj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/konveyor/mig-ui/blob/master/OWNERS)~~ [ibolton336,rayfordj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mturley commented 2 years ago

Hmm, @ibolton336 should we review the rest of the devDependencies to see if anything else needs to be moved over? I can imagine something like that sneaking up on us at run time Edit: gave them a once-over and nothing else jumps out at me

ibolton336 commented 2 years ago

Hmm, @ibolton336 should we review the rest of the devDependencies to see if anything else needs to be moved over? I can imagine something like that sneaking up on us at run time Edit: gave them a once-over and nothing else jumps out at me

@mturley I did a quick check and built images to test. Looked like those were the only two that were causing the image to fail to build. You're instinct to check further gaps is spot on though. Not sure if some other functionality would maybe lazy load during run time like you mentioned. I just looked through the main.js entry point file.

mturley commented 2 years ago

I looked at each of the dependencies left in that list and looked up the ones I didn't recognize, they're all of the build/lint/test/mock variety. I think we're probably good.