migtools / mig-ui

Openshift Migration UI
Apache License 2.0
10 stars 31 forks source link

add/edit replication repository: correct url for generic s3 obeject store #678

Open rbaumgar opened 4 years ago

rbaumgar commented 4 years ago

if you create a replication repository based on a generic s3 object store, e.g. minio and past the wrong url, migration fails.

When you enter "http://minio-gpte-minio.apps.cluster-eb31.eb31.sandbox982.opentlc.com/" with a slash at the end for the S3 endpoint, add repository and check connection works. When you later use this repository you fail, because of a wrong bucket url.

When you remove the "/" at the end of the s3 endpoint, migration works.

CAM version 1.1.1

eriknelson commented 4 years ago

if you create a replication repository based on a generic s3 object store, e.g. minio and past the wrong url, migration fails.

@sseago @jortel Seems like this shouldn't be a ready migstorage if it's not valid? Should this get cloned to the controller repo?

sseago commented 4 years ago

It does seem like the migstorage validation should be catching this.