migtools / openshift-migration-plugin

Velero plugin to support migration of openshift workloads across clusters
Apache License 2.0
3 stars 9 forks source link

Build plugin external image #27

Closed sseago closed 5 years ago

sseago commented 5 years ago

This PR pulls in fixes for the following issues with build/buildconfig:

This commit fixes several problems with the build plugin:

Don't abandon other (pull/push secret) items if image is external Take into account image refs in several locations, not just SourceStrategy Filter image ref consideration on DockerImage kind Only modify push/pull secret if the corresponding secret is the default builder-dockercfg- secret (and is present). For empty secrets, leave empty, and for custom secrets, leave as-is since those are migrated. Take into account push/pull secrets in all relevant locations, not just SourceStrategy and Output. Apply all of the above to BuildConfig as well