search

migtools / openshift-migration-plugin

Velero plugin to support migration of openshift workloads across clusters
Apache License 2.0
3 stars 9 forks source link

Use go modules #50

Closed gildub closed 2 years ago

gildub commented 4 years ago

https://github.com/konveyor/openshift-migration-plugin/issues/51

sseago commented 4 years ago

Looks like some of the deps aren't coming in properly. In particular, it looks like some newer changes in vendor/github.com/containers/image/v5 and vendor/github.com/konveyor/openshift-velero-plugin seem to be missing, causing build errors in the files in this repo that rely on them.

sseago commented 4 years ago

It probably makes sense to get openshift-velero-plugin done first, since this repo includes that one as a dep.

gildub commented 4 years ago

@sseago, yes let's wait until openshift-velero-plugin dep is moved to modules. Thanks

sseago commented 4 years ago

Also, it looks like the containers/image dep is wrong. The modules change is not pulling in the recent upstream change we rely on. This is what we're pulling in via Gopkg.toml that gets the change we need:

[[override]]
  name = "github.com/containers/image"
  revision = "6dbed6e4847ccda0a82a8b72de66e6257fb0edda"
gildub commented 4 years ago

@sseago, You're right, I initially resolved that one using v5.1.0 but a specific commit is needed.