search

migtools / openshift-migration-plugin

Velero plugin to support migration of openshift workloads across clusters
Apache License 2.0
3 stars 9 forks source link

[WIP] Add MigPlan-based labels to restore #71

Closed aufi closed 4 years ago

aufi commented 4 years ago

In order to allow Rollback operation by a migmigration following after other migmigration perfomed the migration operation, it is needed label restored objects by MigPlan to allow identify such objects by the later created rollback migmigration.

Related to https://github.com/konveyor/mig-controller/pull/677 Related to https://github.com/konveyor/mig-controller/issues/663

sseago commented 4 years ago

As of MTC 1.3.0, we're using https://github.com/konveyor/openshift-velero-plugin instead of this one, as we have merged the content of these two previously-separate repos on the master branch of openshift-velero-plugin. This repo is currently only relevant for possible future 1.2.z z-stream releases. We intend to archive the repo once 1.3.0 is released and we are certain that there will be no more 1.2.z releases, so this PR is probably needed against that repo instead of here.

sseago commented 4 years ago

Also, in the openshift-velero-plugin context, the intent is that the plugins are used for both MTC and OADP. In the OADP context, we won't have a migplan label. As long as the plugins work sanely with or without this label being present, it should be fine.

aufi commented 4 years ago

@sseago Hi Scott, thanks for quick review and information!

I think this should not be in 1.2.z releases, so going to make PR against openshift-velero-plugin

aufi commented 4 years ago

Closing in favor of https://github.com/konveyor/openshift-velero-plugin/pull/58