search

migtools / volume-snapshot-mover

https://migtools.github.io/volume-snapshot-mover/developer
Apache License 2.0
17 stars 13 forks source link

OADP-2074: Fix storageClass name passed to configMap Get #237

Closed eemcmullan closed 1 year ago

openshift-ci[bot] commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

eemcmullan commented 1 year ago

/cherry-pick oadp-1.2

openshift-cherrypick-robot commented 1 year ago

@eemcmullan: once the present PR merges, I will cherry-pick it on top of oadp-1.2 in a new PR and assign it to you.

In response to [this](https://github.com/migtools/volume-snapshot-mover/pull/237#issuecomment-1583294958): >/cherry-pick oadp-1.2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shubham-pampattiwar commented 1 year ago

We are updating the storageclass parameter to be used for fetching the datamover volume options configmap from VSB Status to source PVC spec. This change was needed because there might be boundary cases when the VSB status is yet to have storageclass name and the configmap comes out to be nil, in such cases the mirrored PVC will not use the intended storageclass from volume options mapping and it will end up using the incorrect one.

openshift-ci-robot commented 1 year ago

@eemcmullan: This pull request references OADP-2074 which is a valid jira issue.

In response to [this](https://github.com/migtools/volume-snapshot-mover/pull/237): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eemcmullan, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/migtools/volume-snapshot-mover/blob/master/OWNERS)~~ [eemcmullan,sseago] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 1 year ago

@eemcmullan: new pull request created: #239

In response to [this](https://github.com/migtools/volume-snapshot-mover/pull/237#issuecomment-1583294958): >/cherry-pick oadp-1.2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.