search

migtools / volume-snapshot-mover

https://migtools.github.io/volume-snapshot-mover/developer
Apache License 2.0
17 stars 13 forks source link

OADP-2175: Make use of restic secret to pass datamover retain policy instead of datamover config map #245

Closed shubham-pampattiwar closed 1 year ago

shubham-pampattiwar commented 1 year ago

Related to https://github.com/openshift/oadp-operator/pull/1078

openshift-ci-robot commented 1 year ago

@shubham-pampattiwar: This pull request references OADP-2175 which is a valid jira issue.

In response to [this](https://github.com/migtools/volume-snapshot-mover/pull/245): >Related to https://github.com/openshift/oadp-operator/pull/1078 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shubham-pampattiwar commented 1 year ago

/cherry-pick oadp-1.2

openshift-cherrypick-robot commented 1 year ago

@shubham-pampattiwar: once the present PR merges, I will cherry-pick it on top of oadp-1.2 in a new PR and assign it to you.

In response to [this](https://github.com/migtools/volume-snapshot-mover/pull/245#issuecomment-1614013221): >/cherry-pick oadp-1.2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eemcmullan, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/migtools/volume-snapshot-mover/blob/master/OWNERS)~~ [eemcmullan,shubham-pampattiwar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 1 year ago

@shubham-pampattiwar: new pull request created: #246

In response to [this](https://github.com/migtools/volume-snapshot-mover/pull/245#issuecomment-1614013221): >/cherry-pick oadp-1.2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.