search

migtools / volume-snapshot-mover

https://migtools.github.io/volume-snapshot-mover/developer
Apache License 2.0
17 stars 13 forks source link

OADP-2049: Ensure all replicationSources are removed after a successful backup #256

Closed shubham-pampattiwar closed 1 year ago

shubham-pampattiwar commented 1 year ago

Always perform ReplicationSource cleanup by removing checks for retainPolicy or cron schedule for data mover backups.

openshift-ci-robot commented 1 year ago

@shubham-pampattiwar: This pull request references OADP-2049 which is a valid jira issue.

In response to [this](https://github.com/migtools/volume-snapshot-mover/pull/256): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shubham-pampattiwar commented 1 year ago

/cherry-pick oadp-1.2

openshift-cherrypick-robot commented 1 year ago

@shubham-pampattiwar: once the present PR merges, I will cherry-pick it on top of oadp-1.2 in a new PR and assign it to you.

In response to [this](https://github.com/migtools/volume-snapshot-mover/pull/256#issuecomment-1638753684): >/cherry-pick oadp-1.2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@shubham-pampattiwar: This pull request references OADP-2049 which is a valid jira issue.

In response to [this](https://github.com/migtools/volume-snapshot-mover/pull/256): >Always perform ReplicationSource cleanup by removing checks for retainPolicy or cron schedule for data mover backups. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shubham-pampattiwar commented 1 year ago

/hold will merge post discussion in tomorrow's scrum

shubham-pampattiwar commented 1 year ago

/unhold

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/migtools/volume-snapshot-mover/blob/master/OWNERS)~~ [kaovilai,shubham-pampattiwar,sseago] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 1 year ago

@shubham-pampattiwar: new pull request created: #257

In response to [this](https://github.com/migtools/volume-snapshot-mover/pull/256#issuecomment-1638753684): >/cherry-pick oadp-1.2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.