migueesc123 / PowerBIRESTAPI

A Microsoft Power BI Data Connector or Power Query Connector for the Power BI REST API
MIT License
238 stars 74 forks source link

Issue with Secret.txt #21

Closed migueesc123 closed 4 years ago

migueesc123 commented 4 years ago

Hey @ImkeF @klinejordan ! Would you guys mind trying out the new version of the connector, but re-enabling the client_secret for the OAuth token?

Every time that I tried with it, it just gave me an error that it couldn't load the ClientSecret.txt file for some odd reason.

My app works totally fine without the need for the client secret, but I just want to make sure that it'll work for you guys as well.

stjeloma commented 4 years ago

For me, not working without client_secret.

ImkeF commented 4 years ago

Hi @migueesc123 , I've added the secret to the StartLogin (new line of code!) and it worked like a charm for me: image

… But it had also worked without the secret - so maybe that's not really helpful then. /Imke

stjeloma commented 4 years ago

Thanks @ImkeF for me, only working with "client_secret".

ImkeF commented 4 years ago

You're welcome @stjeloma and thanks for testing. Just to be clear: With that adjustment, it works for you?

stjeloma commented 4 years ago

Yes, only include your line number 730 in PBIAPI.pq for client_secret!!!

ImkeF commented 4 years ago

Great! Thanks for confirmation!

migueesc123 commented 4 years ago

Pretty weird how it doesn’t work for me. @klinejordan when you get a chance, could you please test the new code ?

klinejordan commented 4 years ago

Not working for me either way. It's only ever worked for me with the client_secret=client_secret in line 730

migueesc123 commented 4 years ago

Does it work for you if you revert back to the previous version @klinejordan ?

klinejordan commented 4 years ago

@migueesc123 yes, when i revert back to the last pull request it works without issue.

migueesc123 commented 4 years ago

could you please try the new project / mez file? @klinejordan @ImkeF

migueesc123 commented 4 years ago

Closing the issue as it appears to be working for all users that have tested the new version of the connector