search

miguel-a-calles-mba / serverless-stack-termination-protection

Serverless plugin to update the CloudFormation stack termination protection.
MIT License
23 stars 4 forks source link

Feature: Support deploying protection only to specified stages #15

Closed miguel-a-calles-mba closed 5 years ago

lutzklai commented 5 years ago

Hey Miguel, great plugin! I read your article on stack protection and saw that you had talked about protection for specified stacks. I am needing this feature so on my CI server so I can deploy test stage > run integration tests > remove test stage.

I made a PR for how I'm implementing this on my project.

miguel-a-calles-mba commented 5 years ago

@lutzklai, glad you liked the article and thanks for adding this enhancement! The code looks great. I'm going to test and approve the PR soon.

lutzklai commented 5 years ago

Awesome, thanks Miguel!

miguel-a-calles-mba commented 5 years ago

This issue is addressed in https://github.com/miguel-a-calles-mba/serverless-stack-termination-protection/releases/tag/1.0.0.