search

miguel-a-calles-mba / serverless-stack-termination-protection

Serverless plugin to update the CloudFormation stack termination protection.
MIT License
23 stars 4 forks source link

Issue with Constructor? #24

Closed dgorini-ca closed 2 years ago

dgorini-ca commented 2 years ago

Tried this plugin using Serverless Framework 2.X, Node 14.18.3 and npm 6.14.15 but sls deploy throws the following error:

image

The constructor is expecting 3 parameters and destructuring { log } from the 3rd parameter which does not exist and that breaks the stack deployment.

If you have an workaround that would be appreciated.

Thank you.

miguel-a-calles-mba commented 2 years ago

Thanks for sharing the bug. Sorry for the delay in responding.

For now, try using the previous version of the plugin. I bumped to a major version because I feared of a breaking change which you found. I will fix as soon as I can.

miguel-a-calles-mba commented 2 years ago

@dgorini-ca, I released 2.0.1 that has a bug fix. Let me know how it works for you.

miguel-a-calles-mba commented 2 years ago

@dgorini-ca, I assume all is good. I am closing this issue.

dgorini-ca commented 1 year ago

Sorry for the late reply. Yes, issue is fixed thank you.