search

miguel-a-calles-mba / serverless-stack-termination-protection

Serverless plugin to update the CloudFormation stack termination protection.
MIT License
23 stars 4 forks source link

Detected unrecognized CLI options: "--disable-termination-protection" after migrating to serverless 3 #25

Closed blitz555 closed 2 years ago

blitz555 commented 2 years ago

Running serverless "deploy" "--verbose" "--stage=dev" "--disable-termination-protection" resulted in error: Environment: darwin, node 12.22.11, framework 3.12.0 (local), plugin 6.2.1, SDK 4.3.2 Docs: docs.serverless.com Support: forum.serverless.com Bugs: github.com/serverless/serverless/issues For serverless-stack-termination-protection versions 1 and 2 the same error was observed. Running serverless "deploy" "--verbose" "--stage=dev" without the termination protection flag succeeded.

Please help me investigate if the issue is associated with serverless framework or plugin.

miguel-a-calles-mba commented 2 years ago

Thanks for sharing the bug. Sorry for the delay in responding.

For now, try using the previous version of the plugin. I bumped to a major version because I feared a breaking change which you found. I will fix as soon as I can.

miguel-a-calles-mba commented 2 years ago

@blitz555, try out version 2.0.2 with the following CLI command:

serverless "deploy" "--verbose" "--stage=dev" "--param" "disable-termination-protection"
miguel-a-calles-mba commented 2 years ago

@blitz555, were you able to test the bug fix?

miguel-a-calles-mba commented 2 years ago

@blitz555, I assume all is good. I am closing this issue.