search

miguel-arrf / ES-2Sem-2021-Grupo-1

Let's start this amazing journey :D
MIT License
4 stars 0 forks source link

CodeSmell detector imposes start with composed rules #15

Closed miguel-arrf closed 3 years ago

miguel-arrf commented 3 years ago

The code smell detector API imposes that we start any rule with either an AND or an OR block.

If the user wants to create, for example, a rule X, which has only one condition (Y > 10), at the moment, he can't.

We either agree that this is the normal way of functioning, and we change the GUI, or, this API needs to be properly changed.

miguel-arrf commented 3 years ago

The issue is now resolved. We just need to instantiate the CodeSmell with a RuleNode where that RuleNode has the RuleCondition as the first argument, and the left and right nodes are null.