SubmitForm Bug Fix (GET Method, Issue #217, Optional attribute) [travis-ci ERROR Itself] - Githubissues

miguel-perez / smoothState.js

Unobtrusive page transitions with jQuery.

MIT License

4.43k stars 508 forks source link

SubmitForm Bug Fix (GET Method, Issue #217, Optional attribute) [travis-ci ERROR Itself] #362

Open Cow258 opened 6 years ago

Cow258 commented 6 years ago

Fixed thing

GET method
1. action attribute should be optional
2. method attribute should be optional
3. request.data should not repeat again after the end of the url query
POST method
1. action attribute should be optional
2. auto replace (self.location.pathname + self.location.search) when action attribute is empty
Support multipart/form-data for Issue #217

GET method Issue Form tag HTML

<form id="form1" method="get">
    <input id="keyword" name="keyword" type="text" value="test"/>
    <input id="method" name="method" type="text" value="PlanA"/>
    <input id="ok" name="ok" type="submit" value="Submit">
</form>

Old Version

Url will be wrong!
smoothState will be crash!

https://localhost/undefined?keyword=test&ok=Submit&keyword=test&ok=Submit

New Version

Url will be correct!

https://localhost/?keyword=test&method=PlanA&ok=Submit

POST method Issue Form tag HTML

smoothState will be crash!

<form id="form1" method="post" enctype="multipart/form-data">
    <input id="keyword" name="keyword" type="text" value="test"/>
    <input id="method" name="method" type="text" value="PlanA"/>
    <input id="ok" name="ok" type="submit" value="Submit">
</form>