search

miguel250 / MZMailChimpBundle

[UNMAINTAINED] Symfony2 mailchimp bundle
54 stars 26 forks source link

Export DumpList is not working if a value contains a comma #24

Closed Phobetor closed 10 years ago

Phobetor commented 10 years ago

The str_replace/explode hack produces a too large and invalid value array if one of the values contains a comma.

miguel250 commented 10 years ago

Hey @Phobetor thanks for the pull request. Any idea why https://github.com/miguel250/MZMailChimpBundle/blob/master/Tests/Services/Methods/MCExportTest.php#L17 failed?

Phobetor commented 10 years ago

Hey @miguel250 thanks for the fast response. Sorry for not running the tests in the first place.

There was an escaping issue in your test data. The escaping was not handled correctly by the str_replace/explode hack but is by json_decode.

I changed the test data respectively.

I also swapped the parameters given to assertEquals to fix phpunit's output in an error case.

miguel250 commented 10 years ago

Ah Thanks.