search

miguel250 / MZMailChimpBundle

[UNMAINTAINED] Symfony2 mailchimp bundle
54 stars 26 forks source link

Start support MailChimp API v2. #34

Open miguel250 opened 9 years ago

miguel250 commented 9 years ago

Fix: #33 Close: #25

stefantalen commented 9 years ago

Are you applying some kind of coding style?

If not, I'd be willing to make the bits of code that you've finished in this PR compatible with PSR-2.

I'm not really sure if I can just pick the code from the branch API-v2 you've created so let me know what you think.

miguel250 commented 9 years ago

@stefantalen I am not sure yet but I can ping you I get the correct structure and standard.

stefantalen commented 9 years ago

Looks like I can create a new PR based on the branch API-v2, for the file structure you could use PSR-4 since it already kind of has that structure now in the v2-branch.

miguel250 commented 9 years ago

Yeah. You can give it a try. I want to keep all the endpoints in their own classes.

Thanks!

— Miguel Perez

On Tue, Oct 7, 2014 at 7:35 PM, Stefan Talen notifications@github.com wrote:

Looks like I can create a new PR based on the branch API-v2, for the file structure you could use PSR-4 since it already kind of has that structure now in the v2-branch.

Reply to this email directly or view it on GitHub: https://github.com/miguel250/MZMailChimpBundle/pull/34#issuecomment-58280299

stefantalen commented 9 years ago

Looks like a Symfony Bundle should have a recommended structure: http://symfony.com/doc/master/cookbook/bundles/best_practices.html

I guess there is no need for a src folder then.

miguel250 commented 9 years ago

@stefantalen yeah the bundle was following before but they are make changes to the structure in symfony 3. Coming back from Python and Java I had been using src/ but if you see any reason not to use it I am up to changing it back.

It also looks like Symfony uses it too https://github.com/symfony/symfony.

stefantalen commented 9 years ago

@miguel250 I'm not considering the symfony/symfony as a pure bundle so I'm not sure if that applies to the structure.

In the end it doesn't really matter that much, let's keep it in the src-folder just to keep the focus on making this bundle work with the API

medy36 commented 9 years ago

Hello,

i would like to know how i can contribute to this bundle. i really need to delete static segments. i tried to override the bundle by adding this function and it' s working fine

 /**
     * delete segment by ID
     * @return bool
     */
    public function listStaticSegmentDel($seg_id)
    {
        $payload = array(
                'id'    => $this->listId,
        'seg_id' => $seg_id,

        );
        $apiCall = 'listStaticSegmentDel';
        $data = $this->makeRequest($apiCall, $payload);
        return $data;
    }

i finally found the right URLs for all methodes http://apidocs.mailchimp.com/api/1.3/#listrelated
medy36 commented 9 years ago

i have most of the methods needed implemented well in your bundle, tell me if i can contribute to your work. thanks

stefantalen commented 9 years ago

@miguel250 The composer.lock file should not be ignored https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file

miguel250 commented 9 years ago

@stefantalen here says you can ignore it for libraries if you want since it doesn't do anything. https://getcomposer.org/doc/02-libraries.md#lock-file

stefantalen commented 9 years ago

@miguel250 Makes sense :+1:

TomSchillemans commented 9 years ago

I kinda need this bundle, I was wondering if v2 is ready yet. I mean last time something updated was 28 days ago!

evertharmeling commented 9 years ago

Yeah would love to use the v2 version too, at least be able to subscribe to a list (and unsubscribe). Anyway we could help otherwise?

alexandretaz commented 9 years ago

Guys Needs Help for this one?