search

miguel250 / MZMailChimpBundle

[UNMAINTAINED] Symfony2 mailchimp bundle
54 stars 26 forks source link

deleting static segment #37

Open medy36 opened 9 years ago

medy36 commented 9 years ago

am trying to add static segments (Winter/Summer), by using my own condition, am not used to MailChimp so i don't know if am doing things right. any feedback would be very useful Thanks.

medy36 commented 9 years ago

any body there ??

miguel250 commented 9 years ago

@medy36 Here is the methods support for segment in v1 of the API. https://github.com/miguel250/MZMailChimpBundle/blob/master/Services/Methods/MCList.php#L245. Delete is not currently supported. It couple be added on the next version of the bundle/

medy36 commented 9 years ago

@miguel250 i proposed a modification in Services/Methods/MCList.php: /* * delete segment by Id * @return bool / public function listStaticSegmentDel($id) { $payload = array( 'id' => $this->listId, ); $apiCall = 'staticSegmentDel'; // the problem is that this URL is incorrect $result = $this->makeRequest($apiCall, $payload,$id); return $result; }

To use Segment very well we need to add other methods.

miguel250 commented 9 years ago

@medy36 I am okay with adding this change but as part of #34.

medy36 commented 9 years ago

@miguel250 can you please merge #39

miguel250 commented 9 years ago

@medy36 I can't merge this because I am not taking any changes to the old API.