miguelangel-nubla / home-assistant-dewpoint

Home Assistant custom component to calculate dew point using temperature and humidity sensors.
MIT License
37 stars 28 forks source link

Future HA Needs Version Number #5

Open CoveCompound opened 3 years ago

CoveCompound commented 3 years ago

I just installed your dewpoint calculator and get the attached message "No 'version' key in the manifest file for custom integration 'dewpoint'. This will not be allowed in a future version of Home Assistant. Please report this to the maintainer of 'dewpoint'"

Screenshot 2021-03-20 163940
Kevinm94 commented 3 years ago

I just started getting the same message. Any way to fix this?

`Logger: homeassistant.loader Source: loader.py:786 First occurred: 6:44:05 PM (1 occurrences) Last logged: 6:44:05 PM

No 'version' key in the manifest file for custom integration 'dewpoint'. As of Home Assistant 2021.6, this integration will no longer be loaded. Please report this to the maintainer of 'dewpoint' `

tomlut commented 3 years ago

You can add a version number to the manifest file (2nd last line here):

{
  "domain": "dewpoint",
  "name": "DewPoint Sensor Calculator",
  "documentation": "https://github.com/miguelangel-nubla/home-assistant-dewpoint",
  "dependencies": [],
  "codeowners": ["@miguelangel-nubla"],
  "requirements": ["psychrolib==2.1.0"],
  "version": "0.0.0"
}

The file is located here config\custom_components\dewpoint\manifest.json

Note the coma after requirements too.

tomlut commented 3 years ago

I've created a pull request to fix this but the repository may be abandoned.

ehn commented 3 years ago

Given that @miguelangel-nubla seems to be MIA and this integration is now broken on the current HA, I forked the repository and made the minimal change.

aeble commented 3 years ago

Given that @miguelangel-nubla seems to be MIA and this integration is now broken on the current HA, I forked the repository and made the minimal change.

Wouldn't it make sense to use your repository for HACS etc. then, @ehn ? I mean, if @miguelangel-nubla really has abandoned the project, it would certainly be needed to be removed from HACS and the documentation should be changed to point to your fork, shouldn't it?

ehn commented 3 years ago

Sure, if people want to use it, I'll update the docs etc accordingly.

ehn commented 3 years ago

Updated the documentation, manifest etc to reflect the new location. Bumped the version in the manifest from 0.0.0 to 0.0.1. After a while, the update showed up in HACS, though it seems to be using the commit numbers as version identifiers rather than what's in the manifest file:


Update pending

Dew Point Calculator

Installed version: 9a1784f

Available version: ba89011

Remember that you need to restart Home Assistant before changes to integrations (custom_components) are applied.```
ehn commented 3 years ago

Created a version on GitHub. Now it looks a bit nicer in HACS.

ehn commented 3 years ago

And just to be clear so as not to step on anyone's toes, I'm not trying to co-opt this project. Very happy if @miguelangel-nubla wants to keep maintaining it. Just created the fork for my own use and made it public so that not every user has to do the same thing to keep using the component.

taugusti commented 3 years ago

your effort is much appreciated!