miguelbalboa / rfid

Arduino RFID Library for MFRC522
The Unlicense
2.77k stars 1.44k forks source link

Support for Gen2 Chinese card UID change in MIFARE_SetUid #448

Closed snake-4 closed 4 years ago

snake-4 commented 5 years ago

Adds standartCommands bool in parameters of MIFARE_SetUid to add support for changing uid on "Gen2 Magic Cards" as these cards doesn't have backdoor commands and only standart commands. But the backward compatibility of this function breaks as new parameter is added.

Q A
Bug fix? no
New feature? yes
Doc update? no
BC breaks? yes
Deprecations? no
Fixed tickets none
Rotzbua commented 5 years ago

Hi SnakePin, thanks for your pr. Do you have any reference or documentation about gen2? I bought some magic cards for testing half a year ago and they all used the backdoor sequence.

snake-4 commented 5 years ago

Check this link https://s.click.aliexpress.com/e/byaorow9 they are referred as gen2 and as you can see it says MCT can change it's uid and MCT is mobile app, it can only send standart commands to card, and also I have few of these cards.

On Thu, Jan 17, 2019, 22:13 Rotzbua <notifications@github.com wrote:

Hi SnakePin, thanks for your pr. Do you have any reference or documentation about gen2? I bought some magic cards for testing half a year ago and they all used the backdoor sequence.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/miguelbalboa/rfid/pull/448#issuecomment-455294937, or mute the thread https://github.com/notifications/unsubscribe-auth/ARon4LAeuzlVIXPLmUSMHcqfvSJl95Eqks5vEMtygaJpZM4aEGss .

snake-4 commented 5 years ago

And also I would like to add this as reference http://www.proxmark.org/forum/viewtopic.php?id=2404

On Thu, Jan 17, 2019, 23:04 Unknown User <tannayir@gmail.com wrote:

Check this link https://s.click.aliexpress.com/e/byaorow9 they are referred as gen2 and as you can see it says MCT can change it's uid and MCT is mobile app, it can only send standart commands to card, and also I have few of these cards.

On Thu, Jan 17, 2019, 22:13 Rotzbua <notifications@github.com wrote:

Hi SnakePin, thanks for your pr. Do you have any reference or documentation about gen2? I bought some magic cards for testing half a year ago and they all used the backdoor sequence.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/miguelbalboa/rfid/pull/448#issuecomment-455294937, or mute the thread https://github.com/notifications/unsubscribe-auth/ARon4LAeuzlVIXPLmUSMHcqfvSJl95Eqks5vEMtygaJpZM4aEGss .

Rotzbua commented 4 years ago

Done on fork.