miguelbalboa / rfid

Arduino RFID Library for MFRC522
The Unlicense
2.75k stars 1.43k forks source link

Citations without proper link #491

Open grapheo12 opened 5 years ago

grapheo12 commented 5 years ago

In the docs, the citation contains reference numbers which do not have proper links to the original papers.

Rotzbua commented 5 years ago

@grapheo12 Will you fix it? Or is this just a complain about a 5 year old document which looks like copy&paste?

grapheo12 commented 5 years ago

Surely! Just can you help me find the actual papers?

leopold-gravier commented 6 months ago

Hello, Here are replacement links for the broken ones in the documentation.

Ultralight : https://www.nxp.com/docs/en/data-sheet/MF0ICU1.pdf

Ultralight C : https://www.nxp.com/docs/en/data-sheet/MF0ICU2_SDS_32.pdf

I cannot do a pull request right now, but I'll try to do it in a couple of weeks.

Have a nice day, Leopold

Rotzbua commented 6 months ago

@leopold-gravier I the issue creator refer to the word document which is kept for historic reason: https://github.com/miguelbalboa/rfid/blob/master/doc/rfidmifare.doc

leopold-gravier commented 6 months ago

My bad. Here's a backup of the wikipedia page that the documentation quotes : http://web.archive.org/web/20140225202826/https://en.wikipedia.org/wiki/MIFARE . The proper links can be found in the Reference tab. Other thought : It may be wise to say explicitely that the doc is quoting wikipedia