search

miguelcobain / ember-composability-tools

ember-composability-tools - Helpers for building a somewhat different kind of components.
MIT License
39 stars 18 forks source link

When a parent is already set up, `didInsertParent` fires before `didInsertElement` #10

Closed reidab closed 2 years ago

reidab commented 7 years ago

This looks to be related to parent.js:74 + the changes in eadbb005.

Since the move to register children on init() instead of on didInsertElement(), children of an already-setup parent are receiving didInsertParent() on init(). This breaks any code in didInsertParent() that relies on the component's rendered element being present.

reidab commented 7 years ago

Working on a PR for this now.

miguelcobain commented 7 years ago

Would be great to have a failing test.

miguelcobain commented 2 years ago

Closed due to https://github.com/miguelcobain/ember-composability-tools/pull/11#issuecomment-943963569