search

miguelcobain / ember-composability-tools

ember-composability-tools - Helpers for building a somewhat different kind of components.
MIT License
39 stars 19 forks source link

parentComponent seems to be undefined #4

Closed niamleeson closed 7 years ago

niamleeson commented 7 years ago

If I am correct, parentComponent is never set and ember-leaflet tries to re-initialize the base-layer and it fails because it already exists.

miguelcobain commented 7 years ago

This probably should be an ember-leaflet issue.

But I think you're right: https://github.com/miguelcobain/ember-leaflet/blob/master/addon/templates/current/leaflet-map.hbs#L2-L10

We need to yield with the correct property name. Can you PR that?

niamleeson commented 7 years ago

do you mean that containerLayer should be named parentComponent instead?

miguelcobain commented 7 years ago

Exactly.

niamleeson commented 7 years ago

PR is submitted.