search

miguelcobain / ember-composability-tools

ember-composability-tools - Helpers for building a somewhat different kind of components.
MIT License
39 stars 18 forks source link

v1: `this.children` is an empty Set when using Root/Node base class #47

Closed knownasilya closed 3 years ago

knownasilya commented 3 years ago

Used here: https://github.com/knownasilya/google-maps-markup/blob/master/addon/components/google-maps-markup.js#L88

Test by running app. Drawing a circle. Clicking 'pan' and then clicking on the drawn circle. That will hit https://github.com/knownasilya/google-maps-markup/blob/master/addon/components/google-maps-markup.js#L316 where children is accessed.

knownasilya commented 3 years ago

Node is defined here https://github.com/knownasilya/google-maps-markup/blob/master/addon/components/markup-result-item.js#L9 and rendered in the Root here: https://github.com/knownasilya/google-maps-markup/blob/master/addon/components/google-maps-markup.hbs#L80

knownasilya commented 3 years ago

Ah, looks like I need to pass @parent={{this}} to the node