search

miguelcobain / ember-paper

The Ember approach to Material Design.
http://miguelcobain.github.io/ember-paper
MIT License
889 stars 331 forks source link

package.json gitclone #712

Open ultish opened 7 years ago

ultish commented 7 years ago

Hi,

I'm not sure if this is the correct place to post this but here goes:

We currently use ember-paper 0.2 and are looking to upgrade to 1.0 for its new features. We are behind a firewall that we can't poke holes through, so we have our own sonartype nexus repository that we load npm modules into. npm is setup to use this repo and it works fine for most cases.

However, with the latest ember-paper 1.0 releases, there's a package for angular material defined like so: "angular-material-source": "github:angular/material#v1.1.4", This runs a git clone command under the covers which is breaking our builds when running npm install as it doesn't have access to github in order to download angular-material-source.

I don't quite understand why this is done this way as I'm not that familiar with it, but can this be pulled into ember-paper as a normal npm dependency instead without using the github url format?

miguelcobain commented 7 years ago

@ultish the reason is that I couldn't find any npm module with angular material source code. One thing you could do is to configure git to use https instead of SSH. Maybe the firewall would let that through?

ultish commented 7 years ago

@miguelcobain ah yes, I did end up trying a insteadOf rule to force it to use https instead but nope, no access unfortunately.

Wonder if I have to look at something to host the materiial module and point it to that local server, which wouldn't be ideal.

ultish commented 7 years ago

@miguelcobain Is https://www.npmjs.com/package/angular-material different to https://www.npmjs.com/package/angular-material-source? With the later seeming to have stopped at 1.0.10 while the former is at 1.1.14?

miguelcobain commented 7 years ago

@ultish angular-material seems to contain only the built files. We're interested in the original sass stylesheets. angular-material-source module seems to be the correct thing to depend on, but they stopped publishing after 1.0.10. Maybe we could convince them to publish latest versions?