search

miguelcobain / ember-yeti-table

Yeti Table
https://miguelcobain.github.io/ember-yeti-table
MIT License
61 stars 15 forks source link

Change/translate the text in the pagination #446

Closed bracke closed 2 years ago

bracke commented 2 years ago

Hi

I would like to change the text used by the pagination controls component. Is this possible?

Kind regards Bent Bracke

cah-brian-gantzler commented 2 years ago

I dont think it is. We wrote our own pagination component and do not use one provided. That doesnt work so well if you are just using <table.body /> but we dont anywhere. All the data is provided to make that easy.

bracke commented 2 years ago

Sure, but the one provided could easily be extended to support it. Just take in the text as attributes. Would a pull request with such a change be accepted?

miguelcobain commented 2 years ago

@bracke the included pagination component is really nothing special and it is totally optional. But I guess it wouldn't hurt to provide more flexibility to it, making it accept some new arguments.

Not sure how you would deal with this line:

Showing {{@paginationData.pageStart}} to {{@paginationData.pageEnd}} of {{@paginationData.totalRows}} entries

I will consider a PR for this, yes. 👍

bracke commented 2 years ago

Excellent. I will put my thinking cap on.