miguelcobain / ember-yeti-table

Yeti Table
https://miguelcobain.github.io/ember-yeti-table
MIT License
61 stars 15 forks source link

prepack script command #466

Open bgantzler opened 7 months ago

bgantzler commented 7 months ago

In the package.json there is a script command for prepack. @AmauryD should this be here?

When trying to use yeti-table I am getting the following when trying to install via pnpm.

ERR_PNPM_PREPARE_PACKAGE  Failed to prepare git-hosted package fetched from "https://codeload.github.com/miguelcobain/ember-yeti-table/tar.gz/b1cc8db69687540a8ab88dcfbbfc022d60745f52": ember-yeti-table@2.0.0 prepack: `rollup --config`
cah-brian-gantzler commented 6 months ago

@AmauryD reminding you of checking this one as well. Thanks

AmauryD commented 6 months ago

@cah-brian-gantzler Thank you ! This command is used for generating dist before package publication. Did you install ember-yeti-table by using a branch or a git commit ?

cah-brian-gantzler commented 6 months ago

Ill have to try it again, I thought by version but its been a while, let me check and repost

cah-brian-gantzler commented 6 months ago

Hmmm, currently installing from branch master-dist (because we havent releases a 3.0 yet) but thats working. So I guess maybe I had tried master. So yea, I think this is good and I should have closed it. Thanks

Hmmm, looks like I cant close it. Whoever can, please close