search

migueldeicaza / MonoTouch.Dialog

Tools to simplify creating dialogs with the user using MonoTouch
MIT License
430 stars 211 forks source link

FloatElement doesn't support left/right images #170

Open SmartyP opened 11 years ago

SmartyP commented 11 years ago

The docs for FloatElement say that you can provide a left and right UIImage into the constructor, and the constructor does take in a left and right UIImage, however those images are not used and do not appear.

It looks like the left and right image values are not stored, and are not yet used anywhere in FlaotElement, see line 458: https://github.com/migueldeicaza/MonoTouch.Dialog/blob/master/MonoTouch.Dialog/Elements.cs

I just wanted to log the issue to make sure it was tracked. I initially asked about this on the Xamarin forum here: http://forums.xamarin.com/discussion/comment/2667

SmartyP commented 11 years ago

After looking at the history it looks like it was never implemented, and the local Left/Right member properties were removed to get rid of compiler warnings due to them being unused variables.

https://github.com/migueldeicaza/MonoTouch.Dialog/commit/9e281aa2fd17997a85256a8d39a0ac17fe3c8cb2

migueldeicaza commented 11 years ago

That is correct, it is part of my very long to-do list.