migueldeicaza / MonoTouch.Dialog

Tools to simplify creating dialogs with the user using MonoTouch
MIT License
430 stars 211 forks source link

Search - Leaving search field cancels search filter #197

Open henrikweimenhog opened 10 years ago

henrikweimenhog commented 10 years ago

Cancelling a search should in my opinion only happen when tapping the X, not when leaving the search field or tapping something else on the screen.

The simple solution is to remove a line

public override void OnEditingStopped (UISearchBar searchBar) { searchBar.ShowsCancelButton = false; // dont do this -> container.FinishSearch (); }

timrisi commented 10 years ago

What exactly are you looking for here? Do you have an easy repro for what you're talking about? When I do a search, it's only cancelling it when hitting the X, the cancel button, or when tapping through to a new screen from an element. I can tap outside of the search field and toggle switches, move sliders etc without the search being cancelled.